Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to add checks with app ids #1844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tginiotis-at-work
Copy link
Contributor

@tginiotis-at-work tginiotis-at-work commented May 16, 2024

Description

Fixes #1467

Add ability to receive and specify App IDs for required checks in branch protection rules.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@tginiotis-at-work tginiotis-at-work force-pushed the app_ids_for_checks branch 3 times, most recently from 40b3783 to 78778a2 Compare May 16, 2024 10:35
@tginiotis-at-work tginiotis-at-work marked this pull request as ready for review May 17, 2024 14:10
@bitwiseman bitwiseman self-assigned this May 18, 2024
@bitwiseman bitwiseman self-requested a review May 18, 2024 19:09
@bitwiseman bitwiseman removed their assignment May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHBranchProtection using deprecated field in required_status_checks
2 participants