-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for External Group operations #1835
base: main
Are you sure you want to change the base?
Provide support for External Group operations #1835
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
============================================
+ Coverage 80.64% 80.96% +0.31%
- Complexity 2358 2403 +45
============================================
Files 225 233 +8
Lines 7203 7323 +120
Branches 395 399 +4
============================================
+ Hits 5809 5929 +120
Misses 1149 1149
Partials 245 245 ☔ View full report in Codecov by Sentry. |
adad47f
to
934f72a
Compare
|
934f72a
to
8c859c0
Compare
@bitwiseman, is anything else required on my side before continuing the contribution process? |
@bitwiseman Please take a moment to review this Pull Request. It contains important changes that could significantly improve the GitHub Enterprise accounts use. If you notice any issues or have any concerns, do not hesitate to comment. Your feedback is greatly appreciated. |
@JsonProperty("team_id") | ||
@SuppressFBWarnings(value = "UWF_UNWRITTEN_FIELD", justification = "Field comes from JSON deserialization") | ||
private long id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JsonProperty("team_id") | |
@SuppressFBWarnings(value = "UWF_UNWRITTEN_FIELD", justification = "Field comes from JSON deserialization") | |
private long id; | |
@SuppressFBWarnings(value = "UWF_UNWRITTEN_FIELD", justification = "Field comes from JSON deserialization") | |
private long teamId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this same thing for other fields. Jackson will interpret. I'm fine with the method names remaining, but would rather not add unneeded annotations.
* | ||
* @author Miguel Esteban Gutiérrez | ||
*/ | ||
public class GHExternalGroups { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify this to match
https://github.com/hub4j/github-api/blob/main/src/main/java/org/kohsuke/github/GHCommitFilesPage.java
Rename to GHExternalGroupsPage
Make groups
an array.
* | ||
* @author Miguel Esteban Gutiérrez | ||
*/ | ||
class GHExternalGroupsIterable extends PagedIterable<GHExternalGroup> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class GHExternalGroupsIterable extends PagedIterable<GHExternalGroup> { | |
class GHExternalGroupIterable extends PagedIterable<GHExternalGroup> { |
|
||
// TODO: Auto-generated Javadoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO: Auto-generated Javadoc |
final GHException inputException = new GHException("Test", inputCause); | ||
|
||
final Optional<GHException> maybeException = EnterpriseManagedSupport.forOrganization(org) | ||
.handleException(inputException); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think handleException
is more like filterException
. Consider rename, but I'm open to leaving if you feel strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well tested and implemented. Great job!
A few adjustments and renames needed.
Description
Provide support for External Group operations, in particular:
Fixes #1828
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: