Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message listening system #4

Merged
merged 6 commits into from
May 17, 2024

Conversation

Patrick-van-Halm
Copy link
Contributor

Adds the system to listen to Frida agent messages. Requires pull request: Publicize setMethodCallHandler

Resolves: #3

@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks so much for looking into this, I've been meaning to investigate this for a while so this is super helpful.

A few comments here about the details but in general this looks great.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
test/test.spec.ts Show resolved Hide resolved
@pimterry
Copy link
Member

I've now published dbus-native too, so you can update that here whenever you're ready.

By the way, in case you're not aware, HTTP Toolkit Pro is totally free for all contributors to the every repo in this org, and this is already a very helpful contribution already! I've just set you up an account linked to your git email [email protected]. If that sounds useful, you can install HTTP Toolkit from httptoolkit.com, click 'Get Pro' then 'Log into existing account' and enter your email to use it.

@Patrick-van-Halm
Copy link
Contributor Author

and this is already a very helpful contribution already! I've just set you up an account linked to your git email [email protected]. If that sounds

Thank you very much I will definitely look into it :)

@Patrick-van-Halm
Copy link
Contributor Author

@pimterry Interesting how the CI fails on a different test every time. Could you take a look at the code? I applied the requested changes.

@pimterry
Copy link
Member

Yeah, I'm not sure what's happening there. There's definitely been some occasional flakiness in the past, but this seems very unusual. I'm going to do some more testing and see if I can get that fixed.

Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now fixed the tests on main and the seem to be much more reliable. I've rebased the PR and it's all passing 👍

Thanks for those quick changes on this @Patrick-van-Halm! I've added a last couple of tiny comments here, but then I think this will be ready to merge.

package.json Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
test/run-frida-server.ts Outdated Show resolved Hide resolved
@Patrick-van-Halm
Copy link
Contributor Author

@pimterry I have made changes as requested, most where just some oversights thanks for letting me know.

@pimterry pimterry merged commit 2dcbb5c into httptoolkit:main May 17, 2024
8 checks passed
@pimterry
Copy link
Member

Awesome! Thanks for all the hard work here, this is great 👍. I'll do a release in just a sec.

@Patrick-van-Halm Patrick-van-Halm deleted the feat/frida-messages branch May 17, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to listen to the agent messages
3 participants