Pre-crop images as squares for smaller thumbnails #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towerofnix
force-pushed
the
graceful-crop
branch
from
d9c225d
to
ba0968d
Compare
towerofnix
force-pushed
the
graceful-crop
branch
from
ba0968d
to
6a68323
Compare
towerofnix
force-pushed
the
preview
branch
3 times, most recently
from
87c7bd7
to
dcb5206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development:
In effect, this PR crops images to square dimensions for smaller thumbnails so that they are already the correct resolution to fill a square presentation on the website. This affects the
mediumandsmallthumbs only, which are used for cover artworks and grid cells respectively — both square containers. This doesn't affect the larger thumbnails, which are used for commentary (or are supposed to) and the large image preview — both intended to display images at their original aspect ratio.Caveat: Because
mediumnow crops to square, it's never appropriate for display in content. The homepage news box has been adjusted accordingly, although it's only ever displayed one image and that news entry will be pushed out of the latest news by the time this PR lands.That's a blocker because we now might display
mediumthumbs even if we asked forlarge! Specifically, for images which never got alargethumb generated to begin with — that's all images under 800x800, currently.