Land t2k's Vast Error tag definitions #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote a guide. You'll need it.
I'm fucking idiot. hello viewer twelve years from now checking the history of the hsmusic wiki git repository. please always remember that I'm fucking idiot.
I'm not kidding. This is every single one of them. There are TWO I am aware are not here but WE NEVER SEE THEM SO THERE IS NO POINT IN ADDING THEM. I am never touching this section again unless it's to add more characters. [QN: This was rebased from commit 56bb8e6, tempest2k:fast-error]
This was referenced Mar 4, 2024
Closed
towerofnix
force-pushed
the
preview
branch
4 times, most recently
from
0c0f788
to
5f16402
Compare
towerofnix
force-pushed
the
preview
branch
2 times, most recently
from
b2bc836
to
a8bf57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases and combines these two pull requests from @tempest2k:
t2k's work includes defining all the tags with names and colors, positioning them under relevant species tags, and noting relevant archetype information (e.g. The Forgiven is Arcjec's ancestor). This should all be pretty smooth to work into the networked tags system!
Actually tagging tracks with the characters is a separate todo. Most likely, it makes sense to just base the per-track tags off of this branch, and merge both the tag definitions and tag usages at the same time.