Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced FB Workplace Compatibility and added Workplace Group Thread support #2243

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enhanced FB Workplace Compatibility and added Workplace Group Thread support #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd8629d
added fix for workplace messages
May 23, 2023
ce45f47
updated name and version of npm package
May 23, 2023
93103c2
updated package name
May 23, 2023
5bafc84
update git url
May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/botbuilder-adapter-facebook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "botbuilder-adapter-facebook",
"version": "1.0.12",
"name": "@marco.maldonado22/botbuilder-adapter-facebook",
"version": "1.0.13",
"description": "Connect Botkit or BotBuilder to Facebook Messenger",
"main": "lib/index.js",
"typings": "./lib/index.d.ts",
Expand All @@ -26,13 +26,13 @@
"chatbots",
"azure"
],
"homepage": "https://github.com/howdyai/botkit/blob/master/packages/botbuilder-adapter-facebook#readme",
"homepage": "https://github.com/marcopolo39/botkit/blob/master/packages/botbuilder-adapter-facebook#readme",
"bugs": {
"url": "https://github.com/howdyai/botkit/issues"
"url": "https://github.com/marcopolo39/botkit/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/howdyai/botkit.git"
"url": "https://github.com/marcopolo39/botkit.git"
},
"dependencies": {
"botbuilder": "^4.15.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/botbuilder-adapter-facebook/src/facebook_adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@ export class FacebookAdapter extends BotAdapter {
// in case of Checkbox Plug-in sender.id is not present, instead we should look at optin.user_ref
if (!message.sender && message.optin && message.optin.user_ref) {
message.sender = { id: message.optin.user_ref };
} else if (!message.sender){
// Ignore message in case where message sender does not exist. FB Workplace sends messages automatically in some cases and botkit cannot read them causing it to throw an error
return
}

const activity: Activity = {
Expand Down