Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested changes #1752

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Suggested changes #1752

wants to merge 26 commits into from

Commits on Mar 26, 2020

  1. Add suggestion to comment for supported violations

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    2a00258 View commit details
    Browse the repository at this point in the history

  2. Build violation with source

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f05afa1 View commit details
    Browse the repository at this point in the history

  3. Make suggestions for missing space after comma

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    9d6dd92 View commit details
    Browse the repository at this point in the history

  4. Add source to violations

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    8b5f0cf View commit details
    Browse the repository at this point in the history

  5. Only make one suggestion

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    735010b View commit details
    Browse the repository at this point in the history

  6. Use more realistic source examples in tests

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    328f947 View commit details
    Browse the repository at this point in the history

  7. Encrypt the single lines of source code

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    e24fe6b View commit details
    Browse the repository at this point in the history

  8. Style updates

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    8a1b92c View commit details
    Browse the repository at this point in the history

  9. More style changes

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    2a58fe8 View commit details
    Browse the repository at this point in the history

  10. Clean up decryption logic a bit

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    cdd2f6f View commit details
    Browse the repository at this point in the history

  11. Remove concurrent migration option

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    7828c12 View commit details
    Browse the repository at this point in the history

  12. Make suggested changes to security doc

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    774d389 View commit details
    Browse the repository at this point in the history

  13. Drop unnecessary variable

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    47b369d View commit details
    Browse the repository at this point in the history

  14. Use if instead of unless

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    824ce4a View commit details
    Browse the repository at this point in the history

  15. Revert most changes to decrypt

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    b8ddf22 View commit details
    Browse the repository at this point in the history

  16. Add test coverage and simplify #source

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    2c40d3e View commit details
    Browse the repository at this point in the history

  17. Use consistent decrypt coding style

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    3e7f14b View commit details
    Browse the repository at this point in the history

  18. Update tests to include source when required

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    79f5ad2 View commit details
    Browse the repository at this point in the history

  19. Add trailing comma

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    1ab171b View commit details
    Browse the repository at this point in the history

  20. Upgrade administrate

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    143fe95 View commit details
    Browse the repository at this point in the history

  21. Upgrade rails

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    69aa469 View commit details
    Browse the repository at this point in the history

  22. Upgrade puma

    @salbertson
    salbertson committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f1f9b18 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Remove messages instance variable

    @salbertson
    salbertson committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    7d1d863 View commit details
    Browse the repository at this point in the history

  2. Don't update violation.source

    @salbertson
    salbertson committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    405902c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Add newline to suggestions

    @salbertson
    salbertson committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    27f595a View commit details
    Browse the repository at this point in the history

  2. Add newlines to tests to match new suggestion format

    @salbertson
    salbertson committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    d48f119 View commit details
    Browse the repository at this point in the history