Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams search for element(s) inside template tag #957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Streams search for element(s) inside template tag #957

wants to merge 1 commit into from

Conversation

viniciusoyama
Copy link

Up until now StreamElement searches for a target (by id) or targets (by generic css selector) by traversing the DOM using document.getElementById or document.querySelectorAll. These methods doesn't search for tags inside templates.

This PR changes StreamElement to also search for target/targets inside templates.

Ref: #932

@viniciusoyama viniciusoyama force-pushed the stream-search-in-template branch 2 times, most recently from d4a900a to 446896d Compare August 3, 2023 22:57
@viniciusoyama viniciusoyama force-pushed the stream-search-in-template branch 2 times, most recently from bbad463 to 5c98a6a Compare June 11, 2024 22:28
@seanpdoyle
Copy link
Contributor

@jorgemanrubia could you enable CI for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpdoyle seanpdoyle seanpdoyle left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viniciusoyama @seanpdoyle