feat: Add customItemValueDelimiter #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks, could it be merged please? |
|
This is great and helps solve the issue I was having #604 I was looking into this same thing and was struggling to figure out why the space to dash replacement was necessary at all. Do you know what the purpose of the replacement is? For my use, I'd like to maintain the spaces in my items, but I'm not sure if this is going to break the library? |
joshzeldin
reviewed
Dec 31, 2023
| @@ -163,6 +163,7 @@ function Picker({ | |||
| closeOnBackPressed = false, | |||
| extendableBadgeContainer = false, | |||
| onSelectItem = (item) => {} | |||
There was a problem hiding this comment.
I think you're missing a comma here
onSelectItem = (item) => {},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @hossein-zare, saw a potential small issue with the custom item value
.replace()modifier for spaces. This update will allow users to customize the delimiter for the value saved when selecting a custom item and make sure that the delimiter is implemented in all space instances.customItemValueDelimiterdefaults to what was already in place (-)..replace()was replaced (no pun intended) with.replaceAll().Thank you for your feedback!