Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-24126: Retrieve userdata secrets and delete secret #982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CB-24126: Retrieve userdata secrets and delete secret #982

wants to merge 1 commit into from

Conversation

szabolcs-horvath
Copy link
Contributor

@szabolcs-horvath szabolcs-horvath commented Apr 19, 2024 •
edited

No description provided.

@szabolcs-horvath szabolcs-horvath force-pushed the CB-24126 branch 8 times, most recently from 0382177 to dcb1136 Compare May 10, 2024 11:39
@szabolcs-horvath szabolcs-horvath marked this pull request as ready for review May 29, 2024 12:46
@szabolcs-horvath szabolcs-horvath requested a review from a team as a code owner May 29, 2024 12:46
lajosrodek
lajosrodek requested changes Jun 3, 2024
View reviewed changes
Copy link

@lajosrodek lajosrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only one typo.

saltstack/base/salt/prerequisites/usr/bin/user-data-helper.sh Outdated Show resolved Hide resolved
lajosrodek
lajosrodek approved these changes Jun 3, 2024
View reviewed changes
Copy link

@lajosrodek lajosrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

lajosrodek
lajosrodek approved these changes Jun 4, 2024
View reviewed changes
Copy link

@lajosrodek lajosrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lajosrodek lajosrodek lajosrodek approved these changes

@TheTinkerDad TheTinkerDad Awaiting requested review from TheTinkerDad TheTinkerDad is a code owner automatically assigned from hortonworks/cloudbreak-sloth

@sgabor001 sgabor001 Awaiting requested review from sgabor001 sgabor001 is a code owner automatically assigned from hortonworks/cloudbreak-sloth

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@szabolcs-horvath @lajosrodek