Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jewish calendar integration move to config flow #32699

Merged
merged 3 commits into from
May 27, 2024

Conversation

tsvi
Copy link
Contributor

@tsvi tsvi commented May 12, 2024

Proposed change

Add changes to Jewish calendar documentation as part of move to config flow

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label May 12, 2024
@tsvi tsvi requested a review from synesthesiam as a code owner May 12, 2024 15:34
@home-assistant home-assistant bot added the next This PR goes into the next branch label May 12, 2024
Copy link

netlify bot commented May 12, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit dcc0fef
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6653612f3ea3ec0008db34c9
😎 Deploy Preview https://deploy-preview-32699--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

c0ffeeca7
c0ffeeca7 previously approved these changes May 13, 2024
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tsvi 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label May 13, 2024
@yuvalabou
Copy link
Contributor

LGTM

@frenck frenck added the parent-merged The parent PR has been merged already label May 24, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @tsvi 👋

It seems like this PR picked up a merge conflict 😢

Could you maybe take a look?

Thanks! 👍

../Frenck

frenck
frenck previously requested changes May 25, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsy, wrong button. I meant to request a change of course 🤦

need... moar... coffee... ☕️

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 25, 2024 09:02
@tsvi tsvi marked this pull request as ready for review May 26, 2024 16:20
@home-assistant home-assistant bot requested a review from frenck May 26, 2024 16:20
@frenck frenck dismissed their stale review May 27, 2024 06:48

Merge conflict resolved

@c0ffeeca7 c0ffeeca7 merged commit c6de190 into home-assistant:next May 27, 2024
6 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels May 27, 2024
@tsvi tsvi deleted the patch-2 branch May 27, 2024 07:41
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants