Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button platform to Teslemetry #32685

Merged
merged 10 commits into from
May 26, 2024
Merged

Add button platform to Teslemetry #32685

merged 10 commits into from
May 26, 2024

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented May 11, 2024 •
edited

Proposed change

Add button platform, and reformat to table since there will be hundreds of entities later

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels May 11, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@Bre77 Bre77 changed the title Tes button Add button platform to Teslemetry May 11, 2024
@netlify Netlify
Copy link

netlify bot commented May 11, 2024 •
edited

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit ef63acf
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6652e234fd78e400082b0cfb
😎 Deploy Preview https://deploy-preview-32685--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bre77 Bre77 mentioned this pull request May 11, 2024
Merged
20 tasks
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 11, 2024
c0ffeeca7
c0ffeeca7 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny tweaks

source/_integrations/teslemetry.markdown Outdated Show resolved Hide resolved
source/_integrations/teslemetry.markdown Outdated Show resolved Hide resolved
c0ffeeca7
c0ffeeca7 reviewed May 13, 2024
View reviewed changes
source/_integrations/teslemetry.markdown Outdated

{% include integrations/config_flow.md %}

## Entities

### Climate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the climate section removed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a table now, which should have Climate in it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The reason I asked was because I no longer found the different modes, such as the Dog mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really good point. I might just have to add a column for extras or break those out specifically.

FYI there are ~5 other PRs that I'll have to rebase with these changes you suggested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Sorry for that. The reason I changed those headers is because we use sentence-style capitalization also in headers.

Copy link
Contributor Author

@Bre77 Bre77 May 13, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good, easier to get it right now, and for all the others I'll be raising later too.

Just didn't want you to go review them and think it's dejavu.

End state: https://teslemetry.com/docs/home-assistant/features

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, ok. Thank you for the heads up.

c0ffeeca7
c0ffeeca7 previously approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Bre77 👍

c0ffeeca7
c0ffeeca7 previously approved these changes May 14, 2024
View reviewed changes
@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label May 14, 2024
joostlek
joostlek requested changes May 26, 2024
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 26, 2024 07:04
@joostlek joostlek added the parent-merged The parent PR has been merged already label May 26, 2024
@Bre77 Bre77 marked this pull request as ready for review May 26, 2024 07:18
@home-assistant home-assistant bot requested a review from joostlek May 26, 2024 07:18
@joostlek joostlek merged commit 25fd2dc into home-assistant:next May 26, 2024
6 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels May 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@c0ffeeca7 c0ffeeca7 c0ffeeca7 left review comments

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bre77 @joostlek @c0ffeeca7