Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve open and opening state for lock #20808

Merged
merged 3 commits into from
May 21, 2024
Merged

Improve open and opening state for lock #20808

merged 3 commits into from
May 21, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented May 16, 2024

Proposed change

  • Adds state colors for new lock state : orange for opening, red for open
  • Removes pulsing effect on card features buttons when locking and unlocking : because for now pulsing effect is only used for critical states (alarm pending, arming, triggered and lock jammed).
  • Split the isAvailable function into multiple functions : it was confusing with the unavailable state of an entity.
  • Change "Door open" to "Done" when calling the open service : we don't know if the state will be open or opening so I put a generic success message to inform the user that the action has been performed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya
Copy link
Member Author

piitaya commented May 16, 2024

@marcgeurts I ping you on this PR because you created the lock card features (#20539). WDYT of the changes?

Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also change the behavior of a "jammed" door allowing the door to open in a jammed state where it was previously disabled. (Reference: home-assistant/architecture#332 (comment))

@piitaya
Copy link
Member Author

piitaya commented May 19, 2024

@silamon it was modified with this PR (#20539) but it shouldn't not because the PR was focused on card feature.
Not sure what behaviour we want...

@piitaya piitaya merged commit 4cc5d2d into dev May 21, 2024
14 checks passed
@piitaya piitaya deleted the lock-open-opening-fixes branch May 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants