Small performance improvements to ingress forwarding #116457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
integration: hassio
small-pr
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
commented
Apr 30, 2024
| # Simple request | ||
| if result.status in (204, 304) or ( | ||
| content_length is not UNDEFINED | ||
| and (content_length_int := int(content_length or 0)) | ||
| and (content_length_int := int(content_length)) |
There was a problem hiding this comment.
already checked for UNDEFINED
bdraco
commented
Apr 30, 2024
Comment on lines
+180
to
+181
| # default value according to RFC 2616 | ||
| content_type = "application/octet-stream" |
There was a problem hiding this comment.
If its missing aiohttp jumps through some hoops to get here
bdraco
commented
Apr 30, 2024
Comment on lines
-197
to
+209
| content_type or simple_response.content_type | ||
| content_type | ||
| ): | ||
| simple_response.enable_compression() | ||
| return simple_response | ||
|
|
||
| # Stream response | ||
| response = web.StreamResponse(status=result.status, headers=headers) | ||
| response.content_type = result.content_type | ||
| response.content_type = content_type | ||
|
|
||
| try: | ||
| if should_compress(response.content_type): | ||
| if should_compress(content_type): |
There was a problem hiding this comment.
Avoid re-parsing it all over again since we already have it
thecode
approved these changes
Apr 30, 2024
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Eliminate some re-parsing of content_type
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: