Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydrawise to 2024.4.1 #116449

Merged
merged 4 commits into from May 2, 2024
Merged

Conversation

dknowles2
Copy link
Contributor

Proposed change

Bump pydrawise to 2024.4.1

Changes since 2024.3.0: dknowles2/pydrawise@2024.3.0...2024.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ptcryan, mind taking a look at this pull request as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hydrawise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hydrawise Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, can you take a look?

@home-assistant home-assistant bot marked this pull request as draft April 30, 2024 12:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dknowles2
Copy link
Contributor Author

Tests are failing, can you take a look?

👍🏻 Done.

@dknowles2 dknowles2 requested a review from joostlek May 1, 2024 12:12
@dknowles2 dknowles2 requested a review from joostlek May 1, 2024 12:29
@dknowles2 dknowles2 marked this pull request as ready for review May 1, 2024 12:30
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff is failing

@home-assistant home-assistant bot marked this pull request as draft May 1, 2024 12:41
@dknowles2
Copy link
Contributor Author

Ruff is failing

👍🏻 fixed

@dknowles2 dknowles2 marked this pull request as ready for review May 2, 2024 02:19
@home-assistant home-assistant bot requested a review from joostlek May 2, 2024 02:19
@joostlek joostlek merged commit 67e199f into home-assistant:dev May 2, 2024
33 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@dknowles2 dknowles2 deleted the pydrawise-bump branch May 10, 2024 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants