Convert history tests to use async API #116447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
has-tests
integration: history
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
approved these changes
May 2, 2024
emontnemery
commented
May 2, 2024
tests/conftest.py
Outdated
Comment on lines
1584
to
1587
| def setup_recorder_before_hass() -> RecorderInstanceGenerator | None: | ||
| """Mock the recorder. | ||
|
|
||
| Override or parametrize this fixture with a fixture that mocks the recorder, | ||
| in the tests that need to test the recorder. | ||
| """ |
There was a problem hiding this comment.
The name and docstring is a bit misleading.
The fixture should do whatever patching needs to be in place until hass is stopped and the hass fixture has been torn down.
There was a problem hiding this comment.
patch_recorder_before_hass?
Co-authored-by: Martin Hjelmare <[email protected]>
emontnemery
force-pushed
the
history_tests_async
branch
from
244ad3c
to
04bbe27
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Convert history tests to use async API
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: