Don't use coordinator for Button and Event #116408
Conversation
home-assistant
bot
added
cla-signed
core
new-feature
small-pr
|
So this just doesnt make sense? Why use the base class in the first case? If you need it for the availability (which button and event should respect) just ignore the callback. |
That's true but it seems as a pretty common thing to do "by mistake" so this is just to avoid registering for a listener if there is no point in having one. |
| super().__init_subclass__(**kwargs) | ||
| # ButtonEntity and EventEntity provide their own states | ||
| # and should not register to use the coordinator for state updates. | ||
| if ButtonEntity in cls.__mro__ or EventEntity in cls.__mro__: |
There was a problem hiding this comment.
I don't think the coordinator should know about platforms. It's up to each integration to implement the coordinator entity or not do that.
There was a problem hiding this comment.
Comes from the side-discussion here in discord.
It just creates unnecessary overhead by registering listeners for entities which has no use of it.
There was a problem hiding this comment.
Integrations shouldn't use the coordinator entity if they shouldn't use it.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Don't use the coordinator for ButtonEntity and EventEntity as they are providing
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: