Bump pydantic constraint #116401
Bump pydantic constraint #116401
Conversation
home-assistant
bot
added
cla-signed
core
dependency
small-pr
|
Reminder for myself: we need to check if Pydantic 1.10.15 is available as wheel on piwheels. Otherwise we have a lot of people with broken instances |
Shows up the same as 1.10.12 did. |
|
I think we had bad builds of v1 because it needed an old version of cython. Need to verify that we build with old cython before we can bump this |
|
Probably ok core/.github/workflows/wheels.yml Line 184 in 180e178 Need to do a manual wheel build |
|
Looks like we ended up with a non-binary build |
|
We still end up with non-binary builds. I'm not sure what has changed with pydantic |
|
I wonder if we need to set some env to force binary build |
|
Looks like it expects you to use the Makefile to build cython maybe? https://github.com/pydantic/pydantic/blob/v1.10.15/setup.py#L75-L94 |
|
Looks like it should just work but it doesn't seem to. |
|
Looks like it didn't actually try again because it sees the non binary wheel is already built. So we need to get that manually removed before we can reattempt |
|
Can we get this PR merged now and then try to get the cython wheel fixed later? I think this PR needs to be merged so the base virtual env can be re-built for CI to start using the new version. |
|
If we merge this we will end up shipping non-binary pydantic |
|
So it looks what happened is that since its not in skip-binary it pulled the none wheel from pypi and didn't try to build it since pydantic ships a none wheel. |
|
|
When pydantic does a new release they include a none wheel so we do not try to build binary wheels which means we will ship slow versions to users the next time we bump related pr #116401 We need to delete the pydantic-1.10.15-py3-none-any.whl wheel from wheels.home-assistant.io after this PR merges so the next build will be binary
|
We need to get the non-binary wheel deleted off of wheels. That isn't something I have access to do though |
|
https://wheels.home-assistant.io/musllinux/pydantic-1.10.15-cp312-cp312-musllinux_1_2_x86_64.whl built ok waiting for the others |
piwheels blocks building old pydantic 1.x versions because they don't have a way to build with cython 0.29.x and building 1.x with cython 3.x produces broken builds |
|
https://wheels.home-assistant.io/musllinux/pydantic-1.10.15-cp312-cp312-musllinux_1_2_armv6l.whl look like we are just waiting for aarch64 |
|
pydantic-1.10.15-cp312-cp312-musllinux_1_2_aarc..> 30-Apr-2024 18:13 2409142 All there now! |
Proposed change
Bump pydantic to 1.10.15 which adds the
v1interface sotry/exceptblocks are not needed to support v1 and v2 at the same time.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: