Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for NEXHome integration #5469

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

linzh322
Copy link
Contributor

@linzh322 linzh322 commented May 17, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons and the logos are the same. Please either:

  • Drop the logo version (we will automatically fall back to the icon version for the logo)
  • Adjust the logo version to just have the logo (remove the transparent space above/below of the actual logo, trim it).

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 18, 2024 11:28
Copy link
Contributor Author

@linzh322 linzh322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to use the same icon, I have removed the logo icon,thank you!

@linzh322 linzh322 requested a review from frenck May 20, 2024 02:03
@linzh322 linzh322 marked this pull request as ready for review May 21, 2024 09:04
@linzh322 linzh322 marked this pull request as draft May 21, 2024 11:04
@linzh322 linzh322 marked this pull request as ready for review May 22, 2024 01:57
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked upstream, the domain used by this integration is invalid:

CleanShot 2024-05-22 at 08 23 01@2x

Ref: https://github.com/nexhome-org/nexhome-homeassistant-component/blob/ed1e684973a62cd1fa79054f14a025c6b1055b63/custom_components/nexhome/manifest.json#L2

The domain of an integration cannot contain capital letters.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 22, 2024 06:23
@linzh322 linzh322 requested a review from frenck May 22, 2024 07:40
@linzh322 linzh322 marked this pull request as ready for review May 22, 2024 07:41
@linzh322
Copy link
Contributor Author

Yes you are right, I have modified my domain

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @linzh322 👍

../Frenck

@frenck frenck merged commit 7913d74 into home-assistant:master May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants