Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon and logo for resideo_total_connect #5468

Merged
merged 3 commits into from
May 20, 2024

Conversation

schmittx
Copy link
Contributor

@schmittx schmittx commented May 16, 2024

Proposed change

Add icons and logos for resideo_total_connect custom integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: N/A
  • Link to code base pull request: N/A
  • Link to documentation pull request: N/A
  • Link to integration documentation on our website: N/A
  • Link to custom integration repository: link

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos and icons provides do not seem to match the banding used by Resideo:

CleanShot 2024-05-18 at 13 33 29@2x

Please adjust the branding to match the manufacturer branding.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 18, 2024 11:34
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@schmittx
Copy link
Contributor Author

Thanks for catching the Resideo logo branding, I had just copied over the assets from the core integration and didn't check.

I updated the logos to match Resideo branding, however I kept the icons as is because they're matched with the current Total Connect app icons (App Store) (Google Play).

The alternative option is to replace the icons with the Resideo corporate logo "r".

@schmittx schmittx marked this pull request as ready for review May 19, 2024 09:36
@home-assistant home-assistant bot requested a review from frenck May 19, 2024 09:36
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the logos to match Resideo branding, however I kept the icons as is because they're matched with the current Total Connect app icons (App Store) (Google Play).

Sorry, we don't collect that in this repo, we try to capture the manufacturer branding. Please adjust the icons as well.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 20, 2024 10:33
@schmittx
Copy link
Contributor Author

Understood, thanks for clarifying! Icons have been updated now.

@schmittx schmittx marked this pull request as ready for review May 20, 2024 11:27
@home-assistant home-assistant bot requested a review from frenck May 20, 2024 11:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @schmittx 👍

../Frenck

@frenck frenck merged commit 55eca8b into home-assistant:master May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants