Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileDropper widget #6826

Merged
merged 16 commits into from
May 30, 2024
Merged

Add FileDropper widget #6826

merged 16 commits into from
May 30, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 13, 2024

Adds FileDropper widget based on the FilePond library. This upload component has more modern styling, support image previews and now supports chunked uploads, making it possible to upload large files.

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 81.45161% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 81.52%. Comparing base (ec70c62) to head (3ef749d).
Report is 2 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_input.py 72.50% 11 Missing ⚠️
panel/widgets/input.py 80.39% 10 Missing ⚠️
panel/models/file_dropper.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6826       +/-   ##
===========================================
+ Coverage   39.87%   81.52%   +41.64%     
===========================================
  Files         307      319       +12     
  Lines       44938    46895     +1957     
===========================================
+ Hits        17921    38230    +20309     
+ Misses      27017     8665    -18352     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member Author

Thanks for the tests! They look good, could you approve and merge?

@hoxbro hoxbro merged commit 55f71a9 into main May 30, 2024
15 checks passed
@hoxbro hoxbro deleted the file_dropper branch May 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants