Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HoloViews.layout issue #6063

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 16, 2023

Fixes HoloViews.layout issue described in #5628 (comment), i.e. that the widget_layout is shown when it holds no widgets.

image

Todo.

  • Add test cases
  • Get Philipp to review test cases
  • Find issue or place where fix should be implemented.
  • Implement solution

plot = pn.bind(_plot, widget)

@hv_available
def test_holoviews_layout_objects(document, comm):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the below test cases. Thanks.

If you agree that the layout should not contain the widget_layout when its empty. Then we should try to find fix.

The alternative would be to set visible=False dynamically on the widget_layout when it contains no objects.

If you know where the fix should be applied I would appreciate you tell me or implement the fix. I have spent some time without being able to identify the place. Thanks.

UPDATE: LOOKING AT THE HoloViews implementation I can see that I can't expect the widget layout to be in position 1. But I still need to know whether the layout objects should be updated or the widget_layout invisible.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1f049f0) 84.62% compared to head (9a96488) 40.64%.

Files Patch % Lines
panel/tests/pane/test_holoviews.py 42.85% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6063       +/-   ##
===========================================
- Coverage   84.62%   40.64%   -43.99%     
===========================================
  Files         295      295               
  Lines       43976    43983        +7     
===========================================
- Hits        37215    17877    -19338     
- Misses       6761    26106    +19345     
Flag Coverage Δ
ui-tests 40.64% <42.85%> (+<0.01%) ⬆️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant