Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for playwright based pdf export #5913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

philippjfr
Copy link
Member

We should also consider whether we want to abandon the Selenium based png export we use via bokeh and replace it with a Playwright based implementation as well.

  • Add tests
  • Add documentation

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (528f685) 82.58% compared to head (4fd03ba) 84.12%.

Files Patch % Lines
panel/io/save.py 13.04% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5913      +/-   ##
==========================================
+ Coverage   82.58%   84.12%   +1.53%     
==========================================
  Files         291      291              
  Lines       42786    42807      +21     
==========================================
+ Hits        35335    36010     +675     
+ Misses       7451     6797     -654     
Flag Coverage Δ
ui-tests 40.91% <13.04%> (+2.44%) ⬆️
unitexamples-tests 72.39% <13.04%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant