Ci #45
Ci #45
Conversation
ghost
assigned 
|
Changes Unknown when pulling 6252d0b on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling 273e5a6 on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling 9a5138d on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling b6ba8d3 on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling 1be7b62 on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling b5aed28 on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling fe6b6af on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling a1fa156 on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling d753311 on Pierozi:ci into ** on hoaproject:master**. |
|
Changes Unknown when pulling 89529bd on Pierozi:ci into ** on hoaproject:master**. |
1 similar comment
|
Changes Unknown when pulling 89529bd on Pierozi:ci into ** on hoaproject:master**. |
|
@vonglasow @Hywan test on travis is good now. |
Ustring.php
Outdated
| @@ -520,15 +520,15 @@ function (array $matches) { | |||
| ); | |||
| } | |||
|
|
|||
| $string = static::transcode($string, 'UTF-8', 'ASCII//IGNORE//TRANSLIT'); | |||
There was a problem hiding this comment.
Because the test fail like this, and I assumed that the behavior expected was to replace by ascii not ignore.
There is 1 failure:
~> Hoa\Ustring\Test\Unit\Ustring::case_to_ascii_no_transliterator_no_normalizer_try():
In file /home/pierozi/Project/github/pierozi/Ustring/Test/Unit/Ustring.php on line 953, mageekguy\atoum\asserters\phpString() failed: strings are not equal
-Expected
+Actual
@@ -1 +1 @@
-string(26) "Un ete brulant sur la cote"
+string(22) "Un t brlant sur la cte"
|
Excellent, thanks for the hard work! |
|
I would like @vonglasow to review this PR, so that we can close #40, and progress on hoaproject/Central#36. |
|
It's ok for me 👍 |
|
@Hywan have you a idea why we have this dependency issue since you merge master? |
|
Like now the composer require @Hywan Should we update all to |
Sequel to #40
I've created this PR here instead of on @vonglasow repository because I'm facing strange behavior on Travis and prefer to let PR hook of the original repository to trigger Travis.