This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
#21 Added support for embedded directions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boast
changed the title
boast
changed the title
| $this->_direction = static::LTR; | ||
|
|
||
| // Check for LRM or RLM/ARM | ||
| $hasLRM = 0 !== preg_match('#\x{200e}#u', $this->_string); |
There was a problem hiding this comment.
I prefer to use constant for LRM & co. in the regular expression :-).
There was a problem hiding this comment.
The problem here is, that the already defined static constant (LRM, RLM, ARM, etc) cannot be easily included in the regular expression, as they are only integers and regular expression use a \x{codepoint syntax - given the u modifier at the end. So no easy solution for that..
There was a problem hiding this comment.
'#\x{' . dechex(self::LRM) . '}#u', thoughts?
There was a problem hiding this comment.
why not :) ill change it accordingly
|
Thanks a lot for this PR \o/. |
| mb_substr($this->_string, 0, 1) | ||
| ); | ||
| // Default | ||
| $this->_direction = static::LTR; |
There was a problem hiding this comment.
Set Default Direction to LTR
|
ping? |
|
@boast ping? |
1 similar comment
|
@boast ping? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit by @Hywan: Fix #21.