Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispose of controller status listener #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

dispose of controller status listener #51

wants to merge 3 commits into from

Conversation

jayjah
Copy link

@jayjah jayjah commented Jul 29, 2021

No description provided.

@jayjah jayjah mentioned this pull request Jul 29, 2021
Open
@adrinr
Copy link

adrinr commented Oct 9, 2021

This PR is fixing performance issues on the web. Without this using it on web just hangs, could it be checked and merge if good?

hnvn
hnvn reviewed Apr 5, 2022
View reviewed changes
Copy link
Owner

@hnvn hnvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small problem about coding convention

lib/shimmer.dart Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnvn hnvn hnvn left review comments

@adrinr adrinr adrinr approved these changes

@mdeandrea-mrmilu mdeandrea-mrmilu mdeandrea-mrmilu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jayjah @adrinr @hnvn @mdeandrea-mrmilu