English version #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
English version about the two parts
hms5232
reviewed
Oct 15, 2020
hms5232
added
documentation
hms5232
reviewed
Oct 18, 2020
| @@ -19,21 +27,49 @@ Python 3.6 or or latest version (For Python2, you can delete `, encoding='UTF-8' | |||
|
|
|||
| 之後程式會自己尋找`ufw.log`這個檔案並輸出成`[YYYYMMDD_HHMMSS].csv`（可自行替換程式碼中輸出和輸入的檔名以符合自己需求），如果有不正確的地方請調整設定：編碼為**UTF-8**、資料有標題、分隔符號為**逗號**。 | |||
|
|
|||
| About the meanings in every item, check https://askubuntu.com/questions/1116145/understanding-ufw-log | |||
| plz put `ufw_log_to_csv.py`and `ufw.log`in the same catalog(copy log or put `ufw_log_to_csv.py`in, I RECOMMAND the former) to execute. | |||
| cd [檔案所在位置] | |||
README.md
Outdated
| @@ -3,12 +3,20 @@ Convert UFW log file to csv. | |||
|
|
|||
| ## 緣起 Introduction | |||
| 在啟用[UFW（Uncomplicated Firewall）](https://zh.wikipedia.org/wiki/Uncomplicated_Firewall)後有時候會打開防火牆產生的日誌看看，但看幾次總覺得原生出來的不太容易閱讀或統計之類的，因此動手寫了一個小程式來幫忙轉成csv。 | |||
| Why I create this little tool? | |||
| Since using [UFW（Uncomplicated Firewall）](https://zh.wikipedia.org/wiki/Uncomplicated_Firewall , I often check the diary(record)generated from the firewall. | |||
There was a problem hiding this comment.
漏掉一個 ) 所以連結渲染怪怪的對吧
Suggested change
| Since using [UFW（Uncomplicated Firewall）](https://zh.wikipedia.org/wiki/Uncomplicated_Firewall , I often check the diary(record)generated from the firewall. | |
| Since using [UFW（Uncomplicated Firewall）](https://zh.wikipedia.org/wiki/Uncomplicated_Firewall) , I often check the diary(record)generated from the firewall. |
Comment on lines
-33
to
+69
| 1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4) | ||
| 1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4o |
hms5232
reviewed
Oct 21, 2020
| @@ -70,8 +70,9 @@ A4: This column is for the exception of the record in brackets. If there is dat | |||
| ## 已知問題 Known issues | |||
| 1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4o | |||
There was a problem hiding this comment.
Suggested change
| 1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4o | |
| 1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4) |
我的 ) 你還沒加回來喔（英文版也別忘了）
|
好啊
可是大致上要完成了是指？
…On Wed, Oct 21, 2020 at 10:12 AM, hms5232 ***@***.***> wrote:
***@***.**** commented on this pull request.
大致上快完成囉，加油！
話說我有在想是不是英文版要另外拉出來成獨立的 README 會比較好排版和對應，你覺得呢？
------------------------------
In README.md
<#7 (comment)>:
> @@ -70,8 +70,9 @@ A4: This column is for the exception of the record in brackets. If there is dat
## 已知問題 Known issues
1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4o
⬇️ Suggested change
-1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](https://github.com/hms5232/ufw-log-to-csv/issues/4o
+1. 當協定為ICMP時有奇怪的紀錄會破壞整個邏輯，詳細見 [issue4](#4)
我的 ) 你還沒加回來喔（英文版也別忘了）
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO2ZNVKFZNX7IBR5MZMMHHTSLY7SXANCNFSM4SSBA3ZQ>
.
|
@jiachiwen PR 主軸內容快完成啦，我只是突然想到是不是要拆分成兩個語言版本的 README。還是之後要的話另外再說，這個 PR 就專心處理翻譯部分？ |
|
可以再多readme沒關係喔
對於譯者來說，不管哪個領域的翻譯都會有所學習到的！我們也會需要去查資料，所以一切都是新的學習(*¯︶¯*)
…On Wed, Oct 21, 2020 at 7:24 PM, hms5232 ***@***.***> wrote:
好啊 可是大致上要完成了是指？
@jiachiwen <https://github.com/jiachiwen> PR
主軸內容快完成啦，我只是突然想到是不是要拆分成兩個語言版本的 README。還是之後要的話另外再說，這個 PR 就專心處理翻譯部分？
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO2ZNVPWBCFLFUIWI36P4CLSL3AFXANCNFSM4SSBA3ZQ>
.
|
@jiachiwen OK 那你最後修正下這個，我進行最後的 Review 並 merge 後再來進行多語言版本切分乙事。 |
|
我開設了一個新分支來處理這事，此 PR 將合併至新分支 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.