Modified to be compatible with more OOP paradigms. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirotakaster
reviewed
Feb 7, 2022
|
|
||
| void MQTT::RegisterCallbackListener(ISubCallback *listener) | ||
| { | ||
| this->callbackListeners.push_back(listener); |
There was a problem hiding this comment.
For thread enable, MutexLocker lock(this) is needed before push_back.
|
Hi @MysteryPoo , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This methodology allows the mqtt driver to exist in non-global space (such as belonging to another wrapper class).
Other features here allow default constructor, with post constructed Initialization (but only a single time).
Also, the callback feature is backwards compatible with a global function callback OR the option of registering
other objects (by means of the ISubCallback interface) to a list of callback listeners.