Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX tweaks for query builder #8518

Conversation

ccschmitz
Copy link
Contributor

@ccschmitz ccschmitz commented May 9, 2024

Summary

  • Only shows errors after submitting a query.
  • Allow empty spaces at the beginning of the query string. This required using a monospace font in order to get the leading space to expand the correct width. Discussed tradeoffs with @julian-highlight and decided to move forward with monospace font for the input + the typeahead results (screenshot below).
  • Trigger submit when a user selects an EXISTS or NOT EXISTS.
Screenshot 2024-05-16 at 9 31 15 AM

How did you test this change?

  • Enter a query that has an error and ensure it is not highlighted until you blur the input.
    • Ensure the state is reset if you fix the error and introduce a new one.
  • Enter empty space at the beginning of the query string and ensure formatting looks correct.
  • Select an EXISTS or NOT EXISTS value and ensure the form submits and behaves as expected.
  • Enter a number of different queries and ensure the search form behaves as expected.

Are there any deployment considerations?

N/A - all client-side chahnges.

Does this work require review from our design team?

Yes, will need to review the font update w/ @julian-highlight. Might be something we don't want to do and just tolerate in order to use the font we want.

Copy link

linear bot commented May 9, 2024

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 1b1a1c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ccschmitz
Copy link
Contributor Author

I talked through the font change on the query builder with @julian-highlight. He is going to look the preview over and update the mocks and massage things a bit after he gets a chance to play with the monospace font.

@ccschmitz ccschmitz requested review from a team and mayberryzane and removed request for a team May 16, 2024 14:32
@ccschmitz ccschmitz marked this pull request as ready for review May 16, 2024 14:32
@ccschmitz ccschmitz merged commit 8f904d9 into main May 16, 2024
21 checks passed
@ccschmitz ccschmitz deleted the hig-4514-no-suggestions-come-up-when-typing-key-that-is-not-last-in branch May 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants