Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expand link in related resource panel #8515

Conversation

ccschmitz
Copy link
Contributor

@ccschmitz ccschmitz commented May 9, 2024

Summary

Fixes a bug where clicking the expand button in the related resource panel on a trace from the traces page wouldn't work. Also updates to use a Link instead of of navigate and an onClick handler which allows you to command + click or right click to open in a new tab.

How did you test this change?

  • Open a trace from the traces page
  • Click the expand button - nothing should happen :)
  • View other related resources across the app and click the expand button to ensure they work as expected

Are there any deployment considerations?

N/A - client-side change only.

Does this work require review from our design team?

N/A - no change in UI.

Copy link

linear bot commented May 9, 2024

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 0e08b82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ccschmitz ccschmitz requested review from a team and Vadman97 and removed request for a team May 10, 2024 15:12
@ccschmitz ccschmitz marked this pull request as ready for review May 10, 2024 15:12
Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good pending the other product -> related trace issue

frontend/src/components/RelatedResources/TracePanel.tsx Outdated Show resolved Hide resolved
@ccschmitz ccschmitz merged commit 69fbe8d into main May 15, 2024
21 checks passed
@ccschmitz ccschmitz deleted the hig-4592-maxiniming-trace-details-in-related-source-panel-breaks branch May 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants