Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] spelling: connection #548

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 20, 2019

Split from #547

For consideration.

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #548 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #548     +/-   ##
===========================================
+ Coverage     56.27%   56.37%   +0.1%     
- Complexity     1235     1239      +4     
===========================================
  Files           195      195             
  Lines          7901     7904      +3     
  Branches        720      722      +2     
===========================================
+ Hits           4446     4456     +10     
+ Misses         3102     3097      -5     
+ Partials        353      351      -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/net/schmizz/sshj/sftp/Response.java 78.26% <100%> (ø) 9 <0> (ø) ⬇️
src/main/java/net/schmizz/sshj/DefaultConfig.java 89.07% <0%> (+0.09%) 11% <0%> (ø) ⬇️
src/main/java/net/schmizz/sshj/common/Base64.java 19.77% <0%> (+0.35%) 24% <0%> (ø) ⬇️
src/main/java/net/schmizz/sshj/SSHClient.java 57.92% <0%> (+0.6%) 33% <0%> (+1%) ⬆️
...va/net/schmizz/sshj/connection/ConnectionImpl.java 58.53% <0%> (+3.25%) 20% <0%> (+1%) ⬆️
...t/schmizz/sshj/connection/ConnectionException.java 33.33% <0%> (+11.11%) 3% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327a4c4...8f1c7a9. Read the comment docs.

@hierynomus hierynomus self-requested a review as a code owner September 24, 2021 10:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #548 (a99f655) into master (1b258f0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #548      +/-   ##
============================================
- Coverage     64.79%   64.78%   -0.02%     
  Complexity     1460     1460              
============================================
  Files           210      210              
  Lines          8519     8519              
  Branches        778      778              
============================================
- Hits           5520     5519       -1     
+ Misses         2596     2594       -2     
- Partials        403      406       +3     
Impacted Files Coverage Δ
src/main/java/net/schmizz/sshj/sftp/Response.java 79.71% <100.00%> (ø)
...ain/java/net/schmizz/sshj/common/SSHException.java 61.29% <0.00%> (-12.91%) ⬇️
...net/schmizz/sshj/transport/TransportException.java 44.44% <0.00%> (-11.12%) ⬇️
.../main/java/net/schmizz/sshj/sftp/PacketReader.java 91.48% <0.00%> (-4.26%) ⬇️
...hmizz/sshj/connection/channel/AbstractChannel.java 73.12% <0.00%> (-0.63%) ⬇️
...va/net/schmizz/sshj/connection/ConnectionImpl.java 60.16% <0.00%> (+0.81%) ⬆️
...java/net/schmizz/sshj/transport/TransportImpl.java 65.97% <0.00%> (+0.82%) ⬆️
...zz/sshj/connection/channel/ChannelInputStream.java 78.78% <0.00%> (+1.51%) ⬆️
...main/java/net/schmizz/sshj/xfer/scp/SCPEngine.java 76.19% <0.00%> (+3.17%) ⬆️
...t/schmizz/sshj/connection/ConnectionException.java 44.44% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@MauriceReeves-usds MauriceReeves-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good thing to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants