Features/1400 implement unfold operation similar to torch tensor unfold #1419

FOsterfeld · 2024-04-02T14:50:04Z

Due Diligence

General:
- title of the PR is suitable to appear in the Release Notes
Implementation:
- unit tests: all split configurations tested
- unit tests: multiple dtypes tested
- documentation updated where needed

Description

Add the function unfold to the available manipulations. unfold(a, dimension, size, step) for a DNDarray a behaves like torch.Tensor.unfold.

Example:

>>> x = ht.arange(1., 8)
>>> x
DNDarray([1., 2., 3., 4., 5., 6., 7.], dtype=ht.float32, device=cpu:0, split=e)
>>> ht.unfold(x, 0, 2, 1)
DNDarray([[1., 2.],
          [2., 3.],
          [3., 4.],
          [4., 5.],
          [5., 6.],
          [6., 7.]], dtype=ht.float32, device=cpu:0, split=None)
>>> ht.unfold(x, 0, 2, 2)
DNDarray([[1., 2.],
          [3., 4.],
          [5., 6.]], dtype=ht.float32, device=cpu:0, split=None)

Issue/s resolved: #1400

Changes proposed:

Type of change

New feature (non-breaking change which adds functionality)

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

no

github-actions · 2024-04-02T14:54:34Z

Thank you for the PR!

…ilar_to_torch_Tensor_unfold

github-actions · 2024-04-02T15:05:58Z

Thank you for the PR!

github-actions · 2024-04-02T15:13:49Z

Thank you for the PR!

codecov · 2024-04-02T15:29:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (e47b3eb) to head (5cdd986).
Report is 18 commits behind head on main.

❗ Current head 5cdd986 differs from pull request most recent head 9b059f8

Please upload reports for the commit 9b059f8 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   91.71%   91.73%   +0.02%     
==========================================
  Files          80       80              
  Lines       11656    11692      +36     
==========================================
+ Hits        10690    10726      +36     
  Misses        966      966

Flag	Coverage Δ
unit	`91.73% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mrfh92 · 2024-04-03T10:34:16Z

The tests on the CUDA-runner seem to hang at test_manipulations.py for 5 MPI-processes.
This also happens locally on my machine, so there seems to be an error in unfold that results in hanging (most likely an MPI deadlock?)

…> chunk_size more tests

…ilar_to_torch_Tensor_unfold

github-actions · 2024-04-03T15:48:41Z

Thank you for the PR!

…ilar_to_torch_Tensor_unfold

github-actions · 2024-04-08T16:31:20Z

Thank you for the PR!

github-actions · 2024-04-10T10:07:12Z

Thank you for the PR!

…node

…ilar_to_torch_Tensor_unfold

github-actions · 2024-04-10T10:45:30Z

Thank you for the PR!

github-actions · 2024-04-10T10:46:39Z

Thank you for the PR!

for more information, see https://pre-commit.ci

github-actions · 2024-04-10T11:10:08Z

Thank you for the PR!

mrfh92 · 2024-04-15T12:03:27Z

On the Terrabyte cluster, using 8 processes on 2 nodes with 4 GPUs each I get the following error:

ERROR: test_unfold (heat.core.tests.test_manipulations.TestManipulations)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/dss/dsshome1/03/di93zek/heat/heat/core/tests/test_manipulations.py", line 3775, in test_unfold
    ht.unfold(x, 0, min_chunk_size, min_chunk_size + 1)  # no fully local unfolds on some nodes
  File "/dss/dsshome1/03/di93zek/heat/heat/core/manipulations.py", line 4272, in unfold
    ret_larray = torch.cat((unfold_loc, unfold_halo), dimension)
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument tensors in method wrapper_CUDA_cat)

----------------------------------------------------------------------
Ran 32 tests in 26.574s

on CPU, everything seems to work (at least in test_manipulations.py)

…ilar_to_torch_Tensor_unfold

github-actions · 2024-05-31T19:08:13Z

Thank you for the PR!

FOsterfeld · 2024-06-01T10:14:56Z

@ClaudiaComito I have now added a PR description and tests with different datatypes.

github-actions · 2024-06-01T10:16:18Z

Thank you for the PR!

ClaudiaComito

Thanks a lot @FOsterfeld for this PR, this is going to be really useful. I have a few change requests, mostly about simplifying the code by using existing methods. Thanks a lot!

heat/core/manipulations.py

github-actions · 2024-06-04T09:39:18Z

Thank you for the PR!

github-actions · 2024-06-04T10:07:42Z

Thank you for the PR!

github-actions · 2024-06-04T10:21:17Z

Thank you for the PR!

…ided-halo Support one-sided halo for DNDarrays

github-actions · 2024-06-05T10:10:57Z

Thank you for the PR!

github-actions · 2024-06-05T11:41:47Z

Thank you for the PR!

…ilar_to_torch_Tensor_unfold

github-actions · 2024-06-05T11:47:46Z

Thank you for the PR!

…ilar_to_torch_Tensor_unfold

github-actions · 2024-06-10T03:43:38Z

Thank you for the PR!

…ilar_to_torch_Tensor_unfold

github-actions · 2024-06-13T07:48:15Z

Thank you for the PR!

…ilar_to_torch_Tensor_unfold

github-actions · 2024-06-21T03:58:21Z

Thank you for the PR!

FOsterfeld added 4 commits March 19, 2024 16:39

implemented the easy cases and a simple test

4f35da8

general case

ff74451

exception handling, added test with two unfold (2D slices)

ff38eb2

added unfold to manipulations module

b95d40a

FOsterfeld and others added 2 commits April 2, 2024 17:01

added test

e01daf0

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

31fd8b4

…ilar_to_torch_Tensor_unfold

FOsterfeld and others added 3 commits April 3, 2024 17:15

fixed behavior for empty unfold_loc, exception handling for size - 1 …

b334002

…> chunk_size more tests

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

1747481

…ilar_to_torch_Tensor_unfold

wrong exception type in test

2e04c11

FOsterfeld and others added 3 commits April 8, 2024 18:03

fixed wrong exception type in tests

4e9bbe2

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

ad9c797

…ilar_to_torch_Tensor_unfold

fixed test for single node setting

c28b99c

added better docstring

f67ef7e

FOsterfeld and others added 2 commits April 10, 2024 12:40

added test to cover case that there are no fully local unfolds for a …

b40a715

…node

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

8b01812

…ilar_to_torch_Tensor_unfold

FOsterfeld and others added 2 commits April 10, 2024 13:04

fixed test case of no fully local unfolds

713e2ad

[pre-commit.ci] auto fixes from pre-commit.com hooks

b323da8

for more information, see https://pre-commit.ci

fixed error due to unspecified torch device

d833a77

ClaudiaComito removed the Review me label May 27, 2024

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

f3b2c6d

…ilar_to_torch_Tensor_unfold

added tests with different datatypes

6c7ad84

FOsterfeld requested a review from ClaudiaComito June 1, 2024 10:15

ClaudiaComito requested changes Jun 3, 2024

View reviewed changes

FOsterfeld added 2 commits June 4, 2024 11:27

renamed ´dimension´ to ´axis´

9ad8d69

use `DNDarray.counts_displs()´

778eb33

updated docstring

c36d6a8

use sanitize_axis

5cdd986

FOsterfeld requested a review from ClaudiaComito June 4, 2024 10:17

support one-sided halo

63aa686

ClaudiaComito mentioned this pull request Jun 4, 2024

Support one-sided halo for DNDarrays #1509

Merged

4 tasks

Merge pull request #1509 from helmholtz-analytics/features/allow-ones…

9b059f8

…ided-halo Support one-sided halo for DNDarrays

use DNDarray.array_with_halos

04d1217

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

b4d8c6c

…ilar_to_torch_Tensor_unfold

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

bcd64aa

…ilar_to_torch_Tensor_unfold

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

eed36bc

…ilar_to_torch_Tensor_unfold

Merge branch 'main' into features/1400-Implement_unfold-operation_sim…

61a5512

…ilar_to_torch_Tensor_unfold

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Features/1400 implement unfold operation similar to torch tensor unfold #1419

Features/1400 implement unfold operation similar to torch tensor unfold #1419

FOsterfeld commented Apr 2, 2024 •

edited

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

codecov bot commented Apr 2, 2024 •

edited

mrfh92 commented Apr 3, 2024 •

edited

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

mrfh92 commented Apr 15, 2024 •

edited

github-actions bot commented May 31, 2024

FOsterfeld commented Jun 1, 2024

github-actions bot commented Jun 1, 2024

ClaudiaComito left a comment

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 10, 2024

github-actions bot commented Jun 13, 2024

github-actions bot commented Jun 21, 2024

Features/1400 implement unfold operation similar to torch tensor unfold #1419

Are you sure you want to change the base?

Features/1400 implement unfold operation similar to torch tensor unfold #1419

Conversation

FOsterfeld commented Apr 2, 2024 • edited

Due Diligence

Description

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

codecov bot commented Apr 2, 2024 • edited

Codecov Report

mrfh92 commented Apr 3, 2024 • edited

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

mrfh92 commented Apr 15, 2024 • edited

github-actions bot commented May 31, 2024

FOsterfeld commented Jun 1, 2024

github-actions bot commented Jun 1, 2024

ClaudiaComito left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

github-actions bot commented Jun 10, 2024

github-actions bot commented Jun 13, 2024

github-actions bot commented Jun 21, 2024

FOsterfeld commented Apr 2, 2024 •

edited

codecov bot commented Apr 2, 2024 •

edited

mrfh92 commented Apr 3, 2024 •

edited

mrfh92 commented Apr 15, 2024 •

edited