Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validate-license.sh #13030

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated validate-license.sh #13030

wants to merge 2 commits into from

Conversation

Saahiti402
Copy link

The modified code has following features:
1.Readability
2.Syntax simplicity
3.Flexibility

The modified code has proper documentation and has no bugs according to my knowledge

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One small request to remove one of the comment lines

@@ -15,18 +15,13 @@
# limitations under the License.
set -euo pipefail
IFS=$'\n\t'

# removed -not to reduce complexity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can probably be removed since it is only applicable right now since -not is part of the existing validate-license.sh script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants