12987: test toToml int conversion #13012
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
CalvinKrist
force-pushed
the
12987-fix-toToml-float
branch
from
97795db
to
34e14f8
Compare
pull-request-size
bot
added
size/S
CalvinKrist
force-pushed
the
12987-fix-toToml-float
branch
from
34e14f8
to
8d055e2
Compare
pull-request-size
bot
added
size/M
CalvinKrist
commented
May 7, 2024
| // Ensure that toToml processes integers as ints, and not floats | ||
| name: "template with toToml processing an integer", | ||
| cmd: fmt.Sprintf("template '%s'", "testdata/testcharts/issue-12987"), | ||
| golden: "output/issue-12987.txt", |
There was a problem hiding this comment.
Note that this test fails
CalvinKrist
commented
May 7, 2024
| "moby/templates/test5": "", | ||
| "moby/templates/test6": "bar = 9\n", |
There was a problem hiding this comment.
while this test passes
CalvinKrist
commented
May 7, 2024
| }, { | ||
| tpl: `{{ toToml . }}`, | ||
| expect: "bar = 9.0\n", | ||
| vars: map[string]float32{"bar": 9.0}, |
There was a problem hiding this comment.
and this test passes
|
This is failing due to builds not passing. Is it possible you are out of sync with this branch? I will try to build and run it. Also you are missing DCO, that isn't optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: