Downloading chart dependencies and saving them using their alias when one is configured. #12930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When multiple dependencies having the same name but different aliases are specified, dependencies are not saved to disk using their configured alias when executing
helm dependency update
. An error is reported with regards to an invalid version.It seems this issue was reported in the past here and here.
Special notes for your reviewer:
I'm relatively new to Helm, even more so to its codebase. Decided to take a crack at addressing this issue. I'm sure there are many concerns that I have overlooked. Would like to get feedback if this is a solution worth polishing and pursuing.
I have essentially introduced copies of the download and verification functions/methods. If the solution is worth pursuing, some refactoring would be necessary I believe.
If applicable: