Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mail support #10667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Mail support #10667

wants to merge 1 commit into from

Conversation

erasin
Copy link
Contributor

@erasin erasin commented May 3, 2024

@mjholub
Copy link

mjholub commented May 3, 2024

looks good! could you include screenshots please?

@erasin
Copy link
Contributor Author

erasin commented May 4, 2024

截屏2024-05-04 09 31 22

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This grammar seems like a work-in-progress - the last commit was quite a while ago and seems unfinished. I don't have a problem merging a grammar that has a few bugs but this grammar also doesn't have a LICENSE and I'd like to not merge grammars that don't have those since it complicates downstream packaging

@kirawi kirawi added A-language-support Area: Support for programming/text languages upstream labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Email highlighting
4 participants