Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes and changes in the mouse event handler #10653

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

diegostafa
Copy link
Contributor

@diegostafa diegostafa commented May 1, 2024

fixes:

  • avoid yanking when holding a selection and clicking on the gutter
  • avoid adding breakpoints when clicking on the status bar

changes:

  • drag selections/scrolling actions are not blocked by the gutter
  • mouse-click to add breakpoints now require the CTRL modifier
  • right mouse click will run the command select_references_to_symbol_under_cursor instead of selecting a single character (just because selecting a character with both left and right click felt redundant) change mouse right click action #10699

- avoid yanking when holding a selection and clicking on the gutter
- avoid adding breakpoints when clicking on the status bar

changes:
- drag selections are not blocked by the gutter
- mouse-click to add breakpoints now require the CTRL modifier
- right mouse click will run the command `select_references_to_symbol_under_cursor` instead of selecting a single character
@the-mikedavis
Copy link
Member

Could you move the change to use select_references_to_symbol_under_cursor to a separate PR? The fixes are easy to merge once we take a look but what command we should use for a right click could use some discussion. An LSP-driven feature might not make the most sense since it won't do anything or will print to the statusline when you don't have a language server running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants