Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Locate to find openssl command #1982

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

uenz
Copy link
Contributor

@uenz uenz commented Oct 25, 2021

SparkleShare uses several comandline tools to provide functionality. While working on the windows version i saw that openssl was hard coded and sparkleshare expects that openssl is in the path. This is not always given.
So i derived from Command an new Openssl command and use the Locate function to locate the command. In linux and macOS it is located under /usr/bin which is in the searchpath of Locate.
I also added a call to the version check of it to the base controller, so if it is not installed SparkleShare will exit and write a crash_report.txt.
For macOS and linux only an additional line in the logfile will appear:
For macOS Environment | LibreSSL 2.8.3
And for Linux Environment | OpenSSL 1.1.1j
I also enquoted the call of openssl in "" which is a platform independent way to deal with spaces in path.
The goal of this merge request is to tear the monstrous feature/WindowsBuild pull request in smaller parts, so that there remains only a few changes which are easier to catch.

@hbons hbons self-requested a review October 31, 2021 16:30
@uenz
Copy link
Contributor Author

uenz commented Nov 2, 2021

@hbons Is there any change to get the Locate pull requests merged? Unfortunatly the windows version can't handle the path issue without changing common files. I 've choosen this way because Command.cs provided the Locate function and used it only for the git command. An other way would be to extend only the searchpath of the Process.Start call. But with this approach a check of all external programms at startup would not be that easy. Please let me know what needs to be changed or explained that a merge becomes possible.
My goal is still to see awindows installer file version 2.3x on the sparkle share page. ;-)
I could also provide a github actions script to build the macOS, Linux and Windows executables. Unfortunately it was not possible to extend the travis-ci, because the system images thete are to old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant