Dynamic layout for inexhaustive case/indeterminately match case #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigumar1
commented
Oct 23, 2023
| @@ -271,7 +272,11 @@ let rec dhexp_of_uexp = | |||
| | InHole( | |||
| InexhaustiveMatch(Some(Common(Inconsistent(Internal(_))))), | |||
| ) => | |||
| // TODO: review | |||
There was a problem hiding this comment.
Not problematic for now since currently DHExp.InexhaustiveCase behaves exactly the same as DHExp.InconsistentBranches
cyrus-
requested changes
Nov 18, 2023
| @@ -33,6 +33,7 @@ module rec DHExp: { | |||
| | Prj(t, int) | |||
| | Constructor(string) | |||
| | ConsistentCase(case) | |||
| | InexhaustiveCase(MetaVar.t, HoleInstanceId.t, case) | |||
There was a problem hiding this comment.
Instead of having three different case constructs in DHExp, let's merge them into one with an additional flag parameter for when there is an error.
cyrus-
added
the
needs-polish
Base automatically changed from
haz3l-case-redundancy
to
haz3l-case-exhaustiveness
February 13, 2024 17:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.