type assignment for internal expressions #1121
Conversation
…nto haz3l-properties
…nto haz3l-properties
…nto haz3l-properties
ruiz-m
force-pushed
the
haz3l-properties
branch
from
2efdb09
to
7f73d07
Compare
| }) | ||
| |> OptUtil.sequence; | ||
| let ctx' = | ||
| List.fold_left( |
There was a problem hiding this comment.
can probably combine the map above and this fold into one, but not critical
| l2, | ||
| ); | ||
| } else { | ||
| ctx; |
There was a problem hiding this comment.
need to error out in cases like this
| } else { | ||
| ctx; | ||
| }; | ||
| | _ => ctx |
| | _ => None | ||
| }; | ||
| | ApBuiltin(_) | ||
| | BuiltinFun(_) => None |
There was a problem hiding this comment.
need to have a way of checking and looking up the type of a builtin, not just erroring on uses of builtins
| None; | ||
| }; | ||
| | ListLit(_, _, ty, _) => Some(List(ty)) | ||
| | Cons(d1, ListLit(_, _, _, [])) => |
There was a problem hiding this comment.
ListLits have types so don't need to special case nil...
| | _ => None | ||
| }; | ||
| | ListConcat(ListLit(_, _, _, []), d) | ||
| | ListConcat(d, ListLit(_, _, _, [])) => |
cyrus-
changed the title
|
|
||
| switch (typ_cases) { | ||
| | None => None | ||
| | Some(_) => Some(Typ.Unknown(Internal)) |
There was a problem hiding this comment.
let's actually check to make sure that there is at least one branch with an inconsistent type here
| if (Typ.eq(ty, Bool)) { | ||
| let* _ = typ_of_dhexp(ctx, m, d1); | ||
| let* _ = typ_of_dhexp(ctx, m, d2); | ||
| Some(Typ.Unknown(Internal)); |
There was a problem hiding this comment.
also here -- let's actually check to make sure that there is at least one branch with an inconsistent type
| | ExpandingKeyword(_) | ||
| | InvalidText(_) | ||
| | BadConstructor(_) | ||
| | IntLit(_) |
There was a problem hiding this comment.
we should type check in these cases
Adds a module that performs type assignment after conducting elaboration.