Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter log level of garbage collector message (fix #10172) #10173

Closed
wants to merge 1 commit into from

Conversation

typhonius
Copy link
Contributor

Description

The garbage collector runs periodically to free unused memory with the default operation set to occur during quiet periods. In the event that a quiet period does not arise, the garbage collector is forced and a warning generated to inform users this has occured.

As warnings require users to take action, this log message causes confusion. Therefore, the log level of the garbage collection message has been altered from LevelWarn to LevelInfo to provide information that this has occured without expectation of users to take action.

Changelog

Instead of a warning when the GC is forced to run, an info message will be generated.

Component : server

Type: bugfix

Product: community-edition

Short Changelog

Instead of a warning when the GC is forced to run, an info message will be generated.

Long Changelog

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

The garbage collector runs periodically to free unused memory with the
default operation set to occur during quiet periods. In the event that
a quiet period does not arise, the garbage collector is forced and a
warning generated to inform users this has occured.

As warnings require users to take action, this log message causes
confusion. Therefore, the log level of the garbage collection message
has been altered from LevelWarn to LevelInfo to provide information
that this has occured without expectation of users to take action.
@typhonius typhonius requested a review from a team as a code owner March 19, 2024 13:24
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@danieljharvey danieljharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks!

hasura-bot added a commit that referenced this pull request Mar 19, 2024
GITHUB_PR_NUMBER: 10173
GITHUB_PR_URL: #10173

PR-URL: hasura/graphql-engine-mono#10738
Co-authored-by: Adam Malone <[email protected]>
GitOrigin-RevId: 3926af6bbac0081f9510e1bdcc9a5d2c5fa2c515
@hasura-bot hasura-bot closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants