Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE RUB: Retrieve Rename RetrieveById #2649

Merged
merged 30 commits into from
Jul 23, 2023

Conversation

glhays
Copy link
Collaborator

@glhays glhays commented Jul 21, 2023

Closes: #2648

@glhays glhays self-assigned this Jul 21, 2023
@glhays glhays marked this pull request as draft July 21, 2023 22:23
@glhays glhays marked this pull request as ready for review July 22, 2023 00:53
@glhays
Copy link
Collaborator Author

glhays commented Jul 22, 2023

@hassanhabib completely up to you whether you want to review each of these.
The goal was to complete the simple renaming of Retrieve to RetrieveById that had already somewhat been done. In some cases I adhered the 120 character rule. I know that each of these need The Standard upgrade but this task gives me a sense of familiarity to the code base for a start. Would have been easier to do !bam find and replace but what the heck.

@glhays glhays requested a review from hassanhabib July 22, 2023 00:59
@hassanhabib
Copy link
Owner

@hassanhabib completely up to you whether you want to review each of these.
The goal was to complete the simple renaming of Retrieve to RetrieveById that had already somewhat been done. In some cases I adhered the 120 character rule. I know that each of these need The Standard upgrade but this task gives me a sense of familiarity to the code base for a start. Would have been easier to do !bam find and replace but what the heck.

@glhays you can merge them

@glhays
Copy link
Collaborator Author

glhays commented Jul 22, 2023

@hassanhabib merging is blocked.

@hassanhabib hassanhabib merged commit 2d9579c into master Jul 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CODE RUB: Tests Retrieve Renamed RetrieveById
2 participants