ormolu-plugin: don’t request GhcSession for useCLI #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably not the best solution. When ormolu is requested from the command line, it should do its own detection of cabal features. If it has to set up the GhcSession just to get some flags, it blocks saving a file (`formatOnSave = true`), which is a horrible user experience in cases where the session takes a minute or more to set up. Instead, now the plugin only depends on ormolu and the file itself. Fixes haskell#4168
|
cc @georgefst This seems plausible to me. We would need to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not the best solution.
When ormolu is requested from the command line, it should do its own detection of cabal features. If it has to set up the GhcSession just to get some flags, it blocks saving a file (
formatOnSave = true), which is a horrible user experience in cases where the session takes a minute or more to set up.Instead, now the plugin only depends on ormolu and the file itself.
Fixes #4168