UI fix KVv2 in json editor when value is null #27094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
hashishaw
approved these changes
May 17, 2024
| // unfortunately in javascript typeof null returns object | ||
| // this is due to a "historical js bug that will never be fixed" | ||
| // we handle this situation here | ||
| if (obj[key] === null) { |
There was a problem hiding this comment.
Could we instead move this to its own else if block before the 'object' check? that would flatten the logic
hashishaw
reviewed
May 17, 2024
| @@ -30,7 +30,12 @@ export function obfuscateData(obj) { | |||
| for (const key of Object.keys(obj)) { | |||
| if (Array.isArray(obj[key])) { | |||
| newObj[key] = obj[key].map(() => '********'); | |||
| } else if (typeof obj[key] === 'object') { | |||
| } else if (typeof obj[key] === 'object' && obj[key] === null) { | |||
There was a problem hiding this comment.
You can just check if it === null
Suggested change
| } else if (typeof obj[key] === 'object' && obj[key] === null) { | |
| } else if (obj[key] === null) { |
and then below just check if it's type object
There was a problem hiding this comment.
Thank you! I was fearful that it would hit the second else if again, but testing while it does it doesn't seem to break anything.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression PR #24530
Fixes Issue #26709
Note: confirmed that you can in fact pass null as a value using curl, so this was a situation we needed to allow in the UI.
Before:
before.mov
After:
fixed.mov