Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS Auth WIF docs #27054

Merged
merged 7 commits into from
May 23, 2024
Merged

Add AWS Auth WIF docs #27054

merged 7 commits into from
May 23, 2024

Conversation

Zlaticanin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 15, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@Zlaticanin Zlaticanin marked this pull request as ready for review May 15, 2024 18:51
@Zlaticanin Zlaticanin requested a review from a team as a code owner May 15, 2024 18:51
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@Zlaticanin Zlaticanin requested a review from schavis May 23, 2024 19:16
@schavis
Copy link
Contributor

schavis commented May 23, 2024

I added the 1.17 backport label assuming this is a new change, but if the doc updates should publish to the current docs, please make sure to add the 1.16 backport label as well.

vinay-gopalan
vinay-gopalan approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had 1 comment on adding a note on the access_key field, but LGTM otherwise!

website/content/api-docs/auth/aws.mdx Show resolved Hide resolved
@Zlaticanin Zlaticanin merged commit 309d832 into main May 23, 2024
32 checks passed
@Zlaticanin Zlaticanin deleted the VAULT-25156/add-aws-auth-wif-docs branch May 23, 2024 19:58
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schavis schavis schavis approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
backport/1.17.x docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zlaticanin @schavis @vinay-gopalan