azurerm_data_protection_backup_policy_blob_storage - support azure blob vaulted backup

[sinbai]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Currently, Terraform only supports operational backup for Azure Blob backup (operational backup only supports setting the default retention rule). The service team requested to support vault backup for Azure blob backup, which in addition to the default retention rule, also supports user-specified retention rules.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccDataProtectionBackupPolicyBlobStorage_vaultbackup (328.49s)
PASS: TestAccDataProtectionBackupPolicyBlobStorage_basic (302.56s)
PASS: TestAccDataProtectionBackupPolicyBlobStorage_requiresImport (292.32s)

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

[catriona-m]

Thanks for this @sinbai - I just wanted to confirm if this has been tested with the 4.0 flag enabled to ensure there are no problems in the schema or crashes around the deprecated properties? Thanks!

[sinbai]

Thanks for this @sinbai - I just wanted to confirm if this has been tested with the 4.0 flag enabled to ensure there are no problems in the schema or crashes around the deprecated properties? Thanks!

Hi @catriona-m thanks for your reminder. I have updated code and tested with 3.0 and 4.0 as shown below. Could you please take another look?

3.0
PASS: TestAccDataProtectionBackupPolicyBlobStorage_basic (345.85s)
PASS: TestAccDataProtectionBackupPolicyBlobStorage_vaultbackup (332.92s) 
PASS: TestAccDataProtectionBackupPolicyBlobStorage_requiresImport (366.81s)

4.0
PASS: TestAccDataProtectionBackupPolicyBlobStorage_basic (332.16s)
PASS: TestAccDataProtectionBackupPolicyBlobStorage_vaultbackup (319.51s)
PASS: TestAccDataProtectionBackupPolicyBlobStorage_requiresImport (330.56s)

[katbyte]

LGTM 💰