Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypedSDK - update all int struct properties to int64 #25910

Merged
merged 16 commits into from
May 27, 2024

Conversation

jackofallops
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This change updates all int references in the Typed resources to be int64 to align with the values in the SDKs provided by go-azure-sdk

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • TypedSDK - update all int struct properties to int64

@jackofallops jackofallops marked this pull request as ready for review May 13, 2024 13:41
@jackofallops jackofallops requested a review from a team May 13, 2024 13:41
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a couple of overlooked int32s, LGTM 🐐

@jackofallops jackofallops merged commit 57fbbc1 into main May 27, 2024
30 checks passed
@jackofallops jackofallops deleted the e/typedsdk-64bit-ints branch May 27, 2024 08:03
@github-actions github-actions bot added this to the v3.106.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment