ci: skip LICENSE.txt copy for Ent releases
#21055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we do not unintentionally copy CE LICENSE.txt to Ent release artifacts. Also rework Go Build jobs to avoid future sync conflicts by handling CE and Ent builds simultaneously.
zalimeni
added
pr/no-changelog
github-actions
bot
added
type/ci
wangxinyi7
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thanks for your script! All look great! just one tiny comment. Just remember to resolve the conflict before merging the PR. Thank you! @zalimeni
| @@ -10,6 +10,7 @@ on: | |||
| # Push events on the main branch | |||
| - main | |||
| - release/** | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
I guess this is only for test purpose right?
zalimeni
added
backport/ent/1.17
|
Closing this for now as @sarahethompson and RelEng are looking into building this into an action as part of verification follow-up work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #21035 to avoid unintentional side-effects when run outside of CE repo.
LICENSE.txtto Ent release artifacts.Tested here: https://github.com/hashicorp/consul/actions/runs/8974943569