Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving performance of --show #1 #3989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improving performance of --show #1 #3989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
##

- DEScrypt Kernel (1500): Improved performance from 950MH/s to 2200MH/s (RX6900XT) on HIP backend by workaround invalid compile time optimizer
- Performance of --show feature has been improved by removing unnecessary memset calls in potfile_remove_parse function.

##
## Bugs
Expand Down
15 changes: 0 additions & 15 deletions src/potfile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,21 +535,6 @@ int potfile_remove_parse (hashcat_ctx_t *hashcat_ctx)

if (line_hash_len == 0) continue;

if (hash_buf.salt)
{
memset (hash_buf.salt, 0, sizeof (salt_t));
}

if (hash_buf.esalt)
{
memset (hash_buf.esalt, 0, hashconfig->esalt_size);
}

if (hash_buf.hook_salt)
{
memset (hash_buf.hook_salt, 0, hashconfig->hook_salt_size);
}

if (module_ctx->module_hash_decode_potfile != MODULE_DEFAULT)
{
if (module_ctx->module_potfile_custom_check != MODULE_DEFAULT)
Expand Down