fix: [CDS-96839]: fix multitypeinput to have default width #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2478 |
| @@ -204,7 +204,7 @@ export function ExpressionAndRuntimeType<T = unknown>(props: ExpressionAndRuntim | |||
| className={cx(mini ? css.mini : css.main, { | |||
| [css.disabled]: type === MultiTypeInputType.RUNTIME || disabled | |||
| })} | |||
| width={width} | |||
| width={width || '100%'} | |||
There was a problem hiding this comment.
this can break at other places where width is not passed. the default width will be considered as 100%
srdjan-harness
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use the following comments to re-trigger PR Checks
Added
width: 100%to multi type input as default so that it occupies the space within the container and not exceed the container by defaultBefore
After
retrigger jestretrigger prettierretrigger typecheckretrigger eslintretrigger stylelintretrigger buildretrigger titlecheckretrigger ImageSnapshot